Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button label #2130

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Oct 1, 2024

Description

Fixes the button label for config.yml documentation on the "Get Started" page

Category

Bug fix

Why these changes are required?

Fix: #2129

What is the old behavior before changes and new behavior after changes?

Used to say "Create config.yml", now it says "Config.yml documentation"

Issues Resolved

Fix: #2129

Testing

Existing tests pass

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <[email protected]>
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (5495990) to head (8f83c1e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2130   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          97       97           
  Lines        2651     2651           
  Branches      404      411    +7     
=======================================
  Hits         1893     1893           
  Misses        642      642           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cwperks
cwperks previously approved these changes Oct 1, 2024
Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho self-assigned this Oct 1, 2024
@derek-ho derek-ho added the backport 2.x backport to 2.x branch label Oct 1, 2024
cwperks
cwperks previously approved these changes Oct 1, 2024
DarshitChanpura
DarshitChanpura previously approved these changes Oct 1, 2024
.github/actions/run-cypress-tests/action.yml Outdated Show resolved Hide resolved
@RyanL1997
Copy link
Collaborator

Just wanna share one of the solutions we are thinking in observability dashboards: opensearch-project/dashboards-observability#2187. So basically we added a specific step for compilation. cc @Swiddis

RyanL1997
RyanL1997 previously approved these changes Oct 1, 2024
Signed-off-by: Derek Ho <[email protected]>
@derek-ho
Copy link
Collaborator Author

derek-ho commented Oct 2, 2024

Just wanna share one of the solutions we are thinking in observability dashboards: opensearch-project/dashboards-observability#2187. So basically we added a specific step for compilation. cc @Swiddis

Thanks, stole the compile step idea from the above PR and now it's working again. Maybe we should cut an issue to OSD core repo to make sure somebody is aware of this increase. It seems to have happened within the last 2 weeks, before that things were consistently under 600, now it is above.

@cwperks cwperks added the v2.18.0 label Oct 2, 2024
@cwperks cwperks merged commit dc3e5a9 into opensearch-project:main Oct 2, 2024
20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 2, 2024
* Fix button label

Signed-off-by: Derek Ho <[email protected]>

* Debug

Signed-off-by: Derek Ho <[email protected]>

* look for server running instead of bundles compiled

Signed-off-by: Derek Ho <[email protected]>

* increase timeout to 900 seconds

Signed-off-by: Derek Ho <[email protected]>

* Actually change timeout to 900 seconds

Signed-off-by: Derek Ho <[email protected]>

* Try compile step

Signed-off-by: Derek Ho <[email protected]>

* Bash

Signed-off-by: Derek Ho <[email protected]>

* Fix messaging + look for start now that compile is different step

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit dc3e5a9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho pushed a commit that referenced this pull request Oct 2, 2024
* Fix button label



* Debug



* look for server running instead of bundles compiled



* increase timeout to 900 seconds



* Actually change timeout to 900 seconds



* Try compile step



* Bash



* Fix messaging + look for start now that compile is different step



---------


(cherry picked from commit dc3e5a9)

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Rename button + fix link
4 participants