Update nextUrl validation to incorporate serverBasePath

[cwperks]

Description

Update nextUrl validation to incorporate the serverBasePath. All nextUrl's must be prefixed with the basePath, so this PR enhances the check by ensuring that the basePath is present in the nextUrl param.

Category

Enhancement

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.34%. Comparing base (2f8c6f4) to head (9ec678a).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2048   +/-   ##
=======================================
  Coverage   69.34%   69.34%           
=======================================
  Files          96       96           
  Lines        2587     2587           
  Branches      382      382           
=======================================
  Hits         1794     1794           
  Misses        699      699           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DarshitChanpura]

Thanks for adding this @cwperks. Should the mutli auth routes also be validated?
https://github.com/opensearch-project/security-dashboards-plugin/blob/2.x/server/auth/types/multiple/routes.ts#L30

[cwperks]

Should the mutli auth routes also be validated?
https://github.com/opensearch-project/security-dashboards-plugin/blob/2.x/server/auth/types/multiple/routes.ts#L30

It only needs to be added on /login routes. It is not necessary on /auth/type. For multi-auth, the validation is delegated to the concrete auth type.

[opensearch-trigger-bot]

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2048-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a44e26539345c17e066bc3ceb9ff1e5c07d50428
# Push it to GitHub
git push --set-upstream origin backport/backport-2048-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2048-to-1.3.