[Backport 2.16] Update nextUrl validation to incorporate serverBasePath #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fix the nextUrl validation test and test url path using regex Signed-off-by: Craig Perkins <[email protected]> * Update nextUrl validation regex Signed-off-by: Craig Perkins <[email protected]> * Add missing tests Signed-off-by: Craig Perkins <[email protected]> * Combine url split to single line Signed-off-by: Craig Perkins <[email protected]> * Update docstring Signed-off-by: Craig Perkins <[email protected]> * Simplify condition Signed-off-by: Craig Perkins <[email protected]> * Add origin on redirect Signed-off-by: Craig Perkins <[email protected]> * Remove absolute url on redirect Signed-off-by: Craig Perkins <[email protected]> * Update login-page tests Signed-off-by: Craig Perkins <[email protected]> * Remove url.origin Signed-off-by: Craig Perkins <[email protected]> * Account for server base path that can be numeric Signed-off-by: Craig Perkins <[email protected]> * Update docstring Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit a44e265)
opensearch-trigger-bot
bot
requested review from
cliu123,
cwperks,
DarshitChanpura,
derek-ho,
RyanL1997 and
stephen-crawford
as code owners
cwperks
approved these changes
Jul 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.16 #2050 +/- ##
=======================================
Coverage 69.34% 69.34%
=======================================
Files 96 96
Lines 2587 2587
Branches 382 375 -7
=======================================
Hits 1794 1794
Misses 699 699
Partials 94 94 ☔ View full report in Codecov by Sentry. |
Crispy-fried-chicken
added a commit
to Crispy-fried-chicken/security-dashboards-plugin
that referenced
this pull request
Aug 24, 2024
…roject#2048) (opensearch-project#2050) (cherry picked from commit fc4f6a2)
Crispy-fried-chicken
added a commit
to Crispy-fried-chicken/security-dashboards-plugin
that referenced
this pull request
Aug 24, 2024
…roject#2048) (opensearch-project#2050) (cherry picked from commit fc4f6a2) Signed-off-by: Yiheng Cao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a44e265 from #2048