-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable timeout params for deleteIndex API only for serverless #646
Disable timeout params for deleteIndex API only for serverless #646
Conversation
Signed-off-by: Tomoyuki Morita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: can we handle this in RestHighLevelClientWrapper and consider use DeleteIndexRequestBuilder?
RestHighLevelClientWrapper does not have reference to FlintOptions. |
Example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
+1 on Louis' idea on moving new DeleteIndexRequest(osIndexName)
into build method.
but don't think it's necessary
I think current approach is more explicit and easier to read, though there could be some preference. |
Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 06c8c66) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 06c8c66) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Actually, the DeleteIndexRequestBuilder from the library does not appear to be for external use; using the builder pattern externally is possible by extending it, but it is fine to leave it as is. |
…#648) (cherry picked from commit 06c8c66) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#649) (cherry picked from commit 06c8c66) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
timeout
/master_timeout
(= clusterManagerNodeTimeout) params, which is added by the RestHighLevelClient by default. (current version ofopensearch-java
library won't add it automatically, but we are still using2.6.0
(ref)Issues Resolved
#634
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.