Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 0.5] Disable timeout params for deleteIndex API only for serverless #649

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 06c8c66 from #646.

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit 06c8c66)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykmr1224 Do we have issue for AOSS support? I'm concerned we add more and more if-else check everywhere in the codebase.

@ykmr1224
Copy link
Collaborator

@ykmr1224 Do we have issue for AOSS support? I'm concerned we add more and more if-else check everywhere in the codebase.

I put if block as I was not quite sure the effect of this to AOS, looking at the current version of opensearch-java package, those parameters are removed from default parameters, and I suppose we are OK to remove it even for AOS, but I just went safer side for now.

@dai-chen dai-chen merged commit d4ac1b7 into 0.5 Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants