-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add index settings option in create statement #44
Merged
penghuo
merged 8 commits into
opensearch-project:main
from
dai-chen:add-index-settings-option
Oct 4, 2023
Merged
Add index settings option in create statement #44
penghuo
merged 8 commits into
opensearch-project:main
from
dai-chen:add-index-settings-option
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmmusings
previously approved these changes
Sep 26, 2023
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
dai-chen
force-pushed
the
add-index-settings-option
branch
from
September 29, 2023 00:15
f904ed7
to
deeb633
Compare
Signed-off-by: Chen Dai <[email protected]>
dai-chen
requested review from
rupal-bq,
penghuo and
anirudha
as code owners
September 29, 2023 00:33
penghuo
reviewed
Oct 2, 2023
flint-core/src/main/scala/org/opensearch/flint/core/storage/FlintOpenSearchClient.java
Show resolved
Hide resolved
penghuo
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
index_settings
option. Please see doc: https://github.com/dai-chen/opensearch-spark/blob/add-index-settings-option/docs/index.md#create-index-optionsFlintMetadata.indexSettings
field to pass it to Flint client. Will refactor the Flint metadata and finalize spec in Refactoring Flint metadata and build index API #24Example
Issues Resolved
#26
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.