-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support refresh interval and checkpoint location option #39
Merged
dai-chen
merged 9 commits into
opensearch-project:main
from
dai-chen:add-checkpoint-location-option
Sep 26, 2023
Merged
Support refresh interval and checkpoint location option #39
dai-chen
merged 9 commits into
opensearch-project:main
from
dai-chen:add-checkpoint-location-option
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <[email protected]>
dai-chen
changed the title
Support more options in create index statement
Support refresh interval and checkpoint location option in create statement
Sep 20, 2023
dai-chen
changed the title
Support refresh interval and checkpoint location option in create statement
Support refresh interval and checkpoint location option
Sep 20, 2023
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
dai-chen
requested review from
rupal-bq,
vmmusings,
penghuo and
anirudha
as code owners
September 25, 2023 15:34
Signed-off-by: Chen Dai <[email protected]>
penghuo
reviewed
Sep 26, 2023
integ-test/src/test/scala/org/opensearch/flint/spark/FlintSparkSkippingIndexITSuite.scala
Show resolved
Hide resolved
Signed-off-by: Chen Dai <[email protected]>
vmmusings
reviewed
Sep 26, 2023
vmmusings
reviewed
Sep 26, 2023
flint-spark-integration/src/main/scala/org/opensearch/flint/spark/FlintSpark.scala
Show resolved
Hide resolved
Signed-off-by: Chen Dai <[email protected]>
vmmusings
reviewed
Sep 26, 2023
integ-test/src/test/scala/org/opensearch/flint/spark/FlintSparkSkippingIndexSqlITSuite.scala
Show resolved
Hide resolved
vmmusings
reviewed
Sep 26, 2023
} | ||
} | ||
|
||
override def visitPropertyValue(value: PropertyValueContext): String = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like every option value is treated like a string.
Few QQs:
- If user passes some random strings in auto refresh. When will the failure occur?
- [Not related to this PR] Any thoughts on communicating syntax and other errors to user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Yes, it's a map of string passed to
FlintSparkIndexOptions
which will interpret it. - For the error case, currently exception will be thrown when we build DataFrame for streaming job in
FlintSpark
. Let me think about if Spark error is clear enough or can we validate beforehand in Add index settings option in create statement #44. Thanks for the good point!
LGTM |
vmmusings
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refresh_interval
andcheckpoint_location
option and store it in Flint metadataSTRING
token anddeleteIndex()
stop job first bugSparkSqlAstBuilder
and mix-in to Flint parserTODO
Will update user manual with new index options in next PR.Example
Issues Resolved
#26
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.