Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing #800

Merged
merged 43 commits into from
Jun 2, 2023
Merged

Conversation

ryanbogan
Copy link
Member

Description

Fixes publishing to Maven and Sonatype that was broken by #687

Issues Resolved

#798

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ryanbogan and others added 30 commits April 18, 2023 18:41
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan added 3 commits June 1, 2023 18:14
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to try this... but are we losing information in that generated POM?

@ryanbogan
Copy link
Member Author

I thought that the POM would still generated, but it's just by opensearchplugin instead. @owaiskazi19 do you know if that's right?

@owaiskazi19
Copy link
Member

owaiskazi19 commented Jun 1, 2023

I thought that the POM would still generated, but it's just by opensearchplugin instead. @owaiskazi19 do you know if that's right?

Can you test using: https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#testing if the POM file is generated on your local?

@ryanbogan
Copy link
Member Author

@dbwiddis @owaiskazi19 opensearch-sdk-java-2.0.0-SNAPSHOT.pom is generated in the .m2 folder

@owaiskazi19 owaiskazi19 merged commit fbe2b9f into opensearch-project:main Jun 2, 2023
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-800-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fbe2b9fcf2aaa79d8c63f27683ef28a3206418e9
# Push it to GitHub
git push --set-upstream origin backport/backport-800-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-800-to-1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants