Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add integration test framework" #799

Closed
wants to merge 1 commit into from
Closed

Revert "Add integration test framework" #799

wants to merge 1 commit into from
+16 −186

Conversation

owaiskazi19
Copy link
Member

Reverts #687

@owaiskazi19
Revert "Add integration test framework (#687)"
c4f27c7 
This reverts commit 04d9eab.

Signed-off-by: owaiskazi19 <[email protected]>
@owaiskazi19 owaiskazi19 force-pushed the revert-687-add_integ_test_framework branch from 6925331 to c4f27c7 Compare June 1, 2023 17:50
@owaiskazi19 owaiskazi19 mentioned this pull request Jun 1, 2023
Closed
joshpalis
joshpalis approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the backport 1.x label since the original backport isn't merged yet

@owaiskazi19 owaiskazi19 mentioned this pull request Jun 1, 2023
Merged
@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #799 (c4f27c7) into main (eff7635) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #799   +/-   ##
=========================================
  Coverage     43.57%   43.57%           
  Complexity      314      314           
=========================================
  Files            69       69           
  Lines          1983     1983           
  Branches        141      141           
=========================================
  Hits            864      864           
  Misses         1101     1101           
  Partials         18       18

@owaiskazi19
Copy link
Member Author

Closing this PR as #800 fixes the issue.

@owaiskazi19 owaiskazi19 closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpalis joshpalis joshpalis approved these changes

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees
No one assigned
Labels
distinguished-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owaiskazi19 @joshpalis