Added PIT actions #155
Added PIT actions #155
Conversation
nhtruong
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
dblock,
VachaShah and
harshavamsi
as code owners
There was a problem hiding this comment.
@nhtruong this looks good to me. Will you raise a new PR to update the docs?
|
@harshavamsi Imma raise a PR to bump the version before release. |
I think it would be good to add the new API usage to the user guide, I understand the user guide might become increasingly large but maybe we can take those examples and add them to the docs website too? |
opensearch-api/lib/opensearch/api/actions/cat/all_pit_segments.rb
Outdated
Show resolved
Hide resolved
Removed Legacy X-Pack Point-In-Time API Signed-off-by: Theo Truong <[email protected]>
|
@dblock @harshavamsi @VachaShah Would you mind taking another look? All concerns have already been addressed |
| @@ -24,7 +26,8 @@ Import the client: | |||
| `require 'opensearch'` | |||
|
|
|||
| ## Sample code | |||
|
|
|||
| <a name="basic-usage" /></a> | |||
There was a problem hiding this comment.
GitHub markdown automatically creates #basic-usage.
| index = :movies | ||
| client.indices.create(index: 'movies') | ||
|
|
||
| # CREATE 3 PITS |
| def all_pit_segments(arguments = {}) | ||
| arguments = arguments.clone | ||
| headers = arguments.delete(:headers) || {} | ||
|
|
There was a problem hiding this comment.
Double space, ... we should really add rubocop.
There was a problem hiding this comment.
I miss Rubocop. Will incorporate along with generated Ruby Client.
| let(:expected_args) do | ||
| [ | ||
| 'POST', | ||
| 'movies,books/_search/point_in_time', |
There was a problem hiding this comment.
wait, this seems wrong! does it support multiple indexes like this?
There was a problem hiding this comment.
Description
Added PIT Actions
Issues Resolved
closes #136
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.