Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Don't modify incoming hash parameters #158

Open
dblock opened this issue Mar 23, 2023 · 0 comments
Open

[BUG] Don't modify incoming hash parameters #158

dblock opened this issue Mar 23, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dblock
Copy link
Member

dblock commented Mar 23, 2023

What is the bug?

Coming from #155 (comment) replace all modifying of incoming hashes by duping them. See https://code.dblock.org/2020/11/11/dup-dont-modify-input-hash-parameters-in-ruby.html for some horror stories.

What is the expected behavior?

Do not modify hashes.
Add tests.
@dblock dblock added bug Something isn't working untriaged good first issue Good for newcomers and removed untriaged labels Mar 23, 2023
@dblock dblock mentioned this issue Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @nhtruong