Merge .pyi type stubs inline
#563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 71.10% 71.69% +0.58%
==========================================
Files 85 87 +2
Lines 7774 7875 +101
==========================================
+ Hits 5528 5646 +118
+ Misses 2246 2229 -17
|
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
|
@saimedhi this is ready for review, FYI |
saimedhi
reviewed
Nov 6, 2023
There was a problem hiding this comment.
@dblock, I've reviewed the PR, and from what I understand, API types are added automatically through the generator, while for tests and other files, we add them manually. I've made a few requested changes, and if you agree with them, please make the changes. Thank you for your contribution!
| @@ -71,34 +71,34 @@ async def test_async(client_count=1, item_count=1): | |||
| await asyncio.gather(*[client.close() for client in clients]) | |||
|
|
|||
|
|
|||
| def test(item_count=1, client_count=1): | |||
| def test(item_count: int = 1, client_count: int = 1) -> None: | |||
There was a problem hiding this comment.
type annotation missing for "test_async" function in this file.
There was a problem hiding this comment.
There's another 1000 errors from the missing files that were not previously checked by mypy, including benchmarks and tests. Could we merge this one and I'll work on the rest?
Signed-off-by: dblock <[email protected]>
saimedhi
approved these changes
Nov 6, 2023
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 16, 2023
The new opensearch-py 2.4.1 added mypy stubs in opensearch-project/opensearch-py#563 and they detected an error in our example (and they cause mypy error when the new version is used)
potiuk
added a commit
to apache/airflow
that referenced
this pull request
Nov 16, 2023
The new opensearch-py 2.4.1 added mypy stubs in opensearch-project/opensearch-py#563 and they detected an error in our example (and they cause mypy error when the new version is used)
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
* Merged types into .py code. Signed-off-by: dblock <[email protected]> * Fix: nox -rs generate. Signed-off-by: dblock <[email protected]> * Updated CHANGELOG. Signed-off-by: dblock <[email protected]> * Use lowest common python version for lint. Signed-off-by: dblock <[email protected]> * Fix: don't typeshed. Signed-off-by: dblock <[email protected]> * Removed unneeded comment. Signed-off-by: dblock <[email protected]> * Simplify OPENSEARCH_URL. Signed-off-by: dblock <[email protected]> * Fix: positional ignore_status used as chunk_size. Signed-off-by: dblock <[email protected]> * Fix: parse version string. Signed-off-by: dblock <[email protected]> * Remove future annotations for Python 3.6. Signed-off-by: dblock <[email protected]> * Fix: types in documentation. Signed-off-by: dblock <[email protected]> * Improve CHANGELOG text. Signed-off-by: dblock <[email protected]> * Re-added missing separator. Signed-off-by: dblock <[email protected]> * Remove duplicate licenses. Signed-off-by: dblock <[email protected]> * Get rid of Optional[Any]. Signed-off-by: dblock <[email protected]> * Fix docs with AsyncOpenSearch. Signed-off-by: dblock <[email protected]> * Fix: undo comment. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: roma2023 <[email protected]>
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 18, 2024
The new opensearch-py 2.4.1 added mypy stubs in opensearch-project/opensearch-py#563 and they detected an error in our example (and they cause mypy error when the new version is used) GitOrigin-RevId: dffe04ada4c05a3e29422f6ea92625c6e040bf10
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 20, 2024
The new opensearch-py 2.4.1 added mypy stubs in opensearch-project/opensearch-py#563 and they detected an error in our example (and they cause mypy error when the new version is used) GitOrigin-RevId: dffe04ada4c05a3e29422f6ea92625c6e040bf10
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 8, 2024
The new opensearch-py 2.4.1 added mypy stubs in opensearch-project/opensearch-py#563 and they detected an error in our example (and they cause mypy error when the new version is used) GitOrigin-RevId: dffe04ada4c05a3e29422f6ea92625c6e040bf10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge .pyi files inline for those files that were previously covered by mypy. Many
Anythat should not be, but it gets us started to have a fully typed library that is edited at the same time as code. This should greatly improve code clarity, maintainability, and enable better static analysis.I wasn't sure whether this is a good idea, so I found some other projects merging stubs.
Issues Resolved
Closes #536.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.