Fix mypy index property access in opensearch example #35691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
approved these changes
Nov 16, 2023
hussein-awala
approved these changes
Nov 16, 2023
The new opensearch-py 2.4.1 added mypy stubs in opensearch-project/opensearch-py#563 and they detected an error in our example (and they cause mypy error when the new version is used)
potiuk
force-pushed
the
fix-mypy-problem-with-opensearch
branch
from
ddc7b20 to
31b5bb1
Compare
|
Slightly updated -> It must be an array :) |
o-nikolas
approved these changes
Nov 16, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new opensearch-py 2.4.1 added mypy stubs in
opensearch-project/opensearch-py#563 and they detected an error in our example (and they cause mypy error when the new version is used)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.