Finishing #143 #180
Merged
Finishing #143 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed wait mechanism Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
shyim
previously approved these changes
Apr 18, 2024
VachaShah
previously approved these changes
Apr 18, 2024
dblock
force-pushed
the
finish-143
branch
2 times, most recently
from
da50872 to
329d4ed
Compare
dblock
force-pushed
the
finish-143
branch
3 times, most recently
from
bc38c42 to
fb8fbe7
Compare
….12/13. Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
finish-143
branch
3 times, most recently
from
e006ae7 to
75f1c09
Compare
|
In integration tests with unreleased OpenSearch I am still getting |
shyim
reviewed
Apr 18, 2024
| run: | | ||
| composer run integration | ||
| env: | ||
| OPENSEARCH_URL: 'http://localhost:9200' |
There was a problem hiding this comment.
I think, you need to add here the credentials
There was a problem hiding this comment.
It's a min distribution without security.
I was able to reproduce this localy. It just needs -E discovery.type=single-node and to swap the order of checking out repos so it doesn't overwrite/delete files.
dblock
force-pushed
the
finish-143
branch
6 times, most recently
from
07234c5 to
5ffcda8
Compare
Signed-off-by: dblock <[email protected]>
Closed
shyim
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finish up #143.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.