Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds newer OpenSearch builds to integration tests and updates unreleased to use new caching mechanism #143

Conversation

harshavamsi
Copy link
Collaborator

Description

Adds newer OpenSearch builds to integration tests and updates unreleased to use new caching mechanism

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…sed to use new caching mechanism

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #143 (e1f426f) into main (967eb3f) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main     #143   +/-   ##
=========================================
  Coverage     24.05%   24.05%           
  Complexity     1921     1921           
=========================================
  Files           243      243           
  Lines          6804     6804           
=========================================
  Hits           1637     1637           
  Misses         5167     5167           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
shyim
shyim previously approved these changes Mar 31, 2023
dblock
dblock previously approved these changes Apr 3, 2023
@dblock
Copy link
Member

dblock commented Apr 3, 2023

Care to look at test failures?

@shyim
Copy link
Collaborator

shyim commented Apr 3, 2023

Is there a config missing? Never saw before cluster_manager_not_discovered_exception

@harshavamsi
Copy link
Collaborator Author

Is there a config missing? Never saw before cluster_manager_not_discovered_exception

Yeah I don't understand what is going on. Looks like it is not able to discover the cluster, but the cluster is running in a previous step -- https://github.com/opensearch-project/opensearch-php/actions/runs/4577473959/jobs/8082928712#step:8:57

path: opensearch/distribution/archives/linux-tar/build/distributions
key: ${{ steps.get-key.outputs.key }}

- uses: actions/setup-java@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think setting up java is needed here.

@@ -53,9 +74,6 @@ jobs:
run: |
composer install --prefer-dist

- name: Wait for Search server
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave the wait for server script so that cluster is available when the integration tests run.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea maybe it is the wait for script for the cluster error

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
@harshavamsi harshavamsi dismissed stale reviews from dblock and shyim via da609ad April 4, 2023 20:24
@VachaShah
Copy link
Collaborator

@harshavamsi Want to finish this?

@dblock dblock mentioned this pull request Apr 18, 2024
@dblock
Copy link
Member

dblock commented Apr 18, 2024

Finishing this in #180.

@dblock dblock closed this Apr 18, 2024
dblock added a commit that referenced this pull request Apr 19, 2024
* Adds newer OpenSearch builds to integration tests and updates unreleased wait mechanism

Signed-off-by: dblock <[email protected]>

* Display OpenSearch version in integration tests.

Signed-off-by: dblock <[email protected]>

* Added support for OPENSEARCH_INITIAL_ADMIN_PASSWORD with OpenSearch 2.12/13.

Signed-off-by: dblock <[email protected]>

* Set discovery.type.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Co-authored-by: Harsha Vamsi Kalluri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants