Use local abstractions sources instead of packages #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested review from
anirudha,
dblock,
joshuali925 and
wbeckler
Xtansia
requested changes
Sep 1, 2022
There was a problem hiding this comment.
From the perspective of getting these repos merged with the fewest changes, this is really good. However I'd really like to see the solutions properly reconciled into one, rather than this nesting. Whether that should be part of this or a follow up pass instead is another question.
… `main/HEAD` @ 63bac1681. * Copy abstractions sources * Adopt the abstractions migration * Merge misc files Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
force-pushed
the
dev-os-2.0-integ-local-abstractions
branch
from
e1a5fa5 to
6d39fde
Compare
MitchellGale
previously approved these changes
Sep 1, 2022
dblock
previously approved these changes
Sep 2, 2022
| | Yury Fridlyand | [Yury-Fridlyand](https://github.com/Yury-Fridlyand) | Bit Quill | | ||
| | Max Ksyunz | [MaxKsyunz](https://github.com/MaxKsyunz) | Bit Quill | | ||
| | Forest Vey | [forestmvey](https://github.com/forestmvey) | Bit Quill | | ||
| | Mitchell Gale | [MitchellGale-BitQuill](https://github.com/MitchellGale-BitQuill) | Bit Quill | |
There was a problem hiding this comment.
So we're merging maintainers? :) This can be cleaned up later.
There was a problem hiding this comment.
We are merging everything!
abstractions/README.md
Outdated
| * `MAJOR.MINOR.PATH` where `MAJOR` is still supported as defined by the EOL policy of OpenSearch. | ||
| * Note if the version exists but is not yet released it will resolve as a build candidate | ||
|
|
||
| ## Project Resources |
There was a problem hiding this comment.
Delete all the non-abstraction parts. Things like COC are all at the root, we can't/shouldn't have duplicates in various parts of the repo.
There was a problem hiding this comment.
Updated, thanks!
Signed-off-by: MaxKsyunz <[email protected]>
…ions-no-build Integrate abstractions projects into client build.
Yury-Fridlyand
dismissed stale reviews from dblock and MitchellGale
via
98fe5f9
Xtansia
approved these changes
Sep 3, 2022
dblock
approved these changes
Sep 5, 2022
VachaShah
approved these changes
Sep 6, 2022
This was referenced Sep 6, 2022
This was referenced Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury-Fridlyand [email protected]
Description
Abstractions lib sources were copied into .net client to use in tests. No need any more to store local nuget packages of abstractions, release them or worry about outdated/broken references to them.
Few fixes were made to let workflows pass. I have also update license headers to comply with #69/#78.
See Bit-Quill#40 for more details.
This PR follows option 2 in #86.
Issues Resolved
#86
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.