-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] Add a developer guide for integration tests and usage of abstractions library #86
Comments
For Option 2, does it make sense to jettison the concept of a separate repo, and then there is no more "copying" across code? Without 2 repos, the whole problem goes away, right? |
Right, it is one of the options. |
This makes sense to me -- abstractions is a set of libraries used for integration tests. There's no need to publish them and it's simple enough to do if necessary. |
According to the second method it was decided to copy abstractions in .net repo. |
Abstractions library used in integration tests and it is responsible for downloading, unpacking and installation of OpenSearch cluster.
Updating integration test infrastructure usually requires updates in abstractions, the document to be added should describe how a developer can test and debug abstractions. Default behaviour getting abstractions will be to pull down Abstractions from Nuget however a developer method is still desired.
There are few options to test abstractions locally or in GitHub Actions (GHA) environment. The document should describe at least one of them.
1. Add abstraction binaries to client’s repo as it happens now (as of client 1.0 release).
Pros
Cons
2. Copy abstractions code into clients repo for R&D purposes
Pros
Cons
3. Checkout abstractions and build in the workflow during GHA
There are 2 ways of running test with this method.
Using package reference (like method 1 above):
Using project reference (like method 2 above):
Pros
Cons
4. Have an easy way to do unofficial releases, not visible/available for users
Pros
Cons
The text was updated successfully, but these errors were encountered: