-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Input Manifest for 1.0 maven release. #307
Conversation
Should we call this Add this information to https://github.com/opensearch-project/opensearch-build/blob/main/bundle-workflow/README.md#opensearch-bundle-workflow. Maybe link the versions to the manifests from that README? |
Signed-off-by: Marc Handalian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We/you/someone can also write a unit test that ensures that the manifest loads from Python code.
build: | ||
name: OpenSearch | ||
version: 1.0.0 | ||
components: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is alerting notification also required by any plugin as dependency? We used to publish that too. Just confirming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dblock we would also want alerting/notification, if we are publishing these to maven. Consumed by Index Management 1.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I don't see any artifacts copied in their build script, but they are pushed to maven local.
Lets take this as a follow up, I don't want to hold the others while this gets sorted out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is following up on this? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working on this right now
Signed-off-by: Marc Handalian <[email protected]>
Signed-off-by: Marc Handalian [email protected]
Description
This PR creates a small input manifest to push 1.0 artifacts to maven for the repo's included.
Going forward this will be part of the full bundle release workflow, but for 1.0.0 we do not have solid 1.0 refs for all repos nor do we need to rebuild the full bundle.
Issues Resolved
One of the remaining steps for #20.
This will need to be set up in CI @bbarani and run as part of this jenkins job to build the artifacts.
The next step is to promote with this job.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.