Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: confusion in paths. #322

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 25, 2021

Signed-off-by: dblock [email protected]

Description

Build broke from #307. Python gets confused because it finds a module under tests called git. So renaming that folder fixes our problem.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock marked this pull request as ready for review August 25, 2021 20:16
@@ -21,7 +20,6 @@
args = parser.parse_args()

manifest = BuildManifest.from_file(args.manifest)
basepath = os.path.dirname(os.path.abspath(args.manifest.name))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused.

@dblock dblock requested a review from peternied August 25, 2021 20:18
@peternied peternied merged commit fa8f990 into opensearch-project:main Aug 25, 2021
@dblock dblock deleted the fix-build branch August 25, 2021 22:30
alborotogarcia pushed a commit to alborotogarcia/opensearch-build that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants