Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release issue template #2930

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Nov 22, 2022

Signed-off-by: Zelin Hao [email protected]

Description

Update release issue template based on the 2.4.0 release issue #2649.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner November 22, 2022 01:04
- [ ] OpenSearch / OpenSearch-Dashboards core and components teams finalize their features
__REPLACE with OpenSearch wide initiatives to improve quality and consistency.__

### Release branch readiness - _Ends __REPLACE_RELEASE-minus-14-days__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's Capitalize These Titles Consistently?

I think this should just say "Release Branch"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dblock. Updated all of following suggestions in latest commit.


### Campaigns
### CI/CD (Feature Freeze) - _Ends __REPLACE_RELEASE-minus-12-days__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just "Feature Freeze", there's more than CI/CD.


__REPLACE with OpenSearch wide initiatives to improve quality and consistency.__
- [ ] OpenSearch / OpenSearch-Dashboards core and components teams finalize their features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period at the end.


__REPLACE with OpenSearch wide initiatives to improve quality and consistency.__
- [ ] OpenSearch / OpenSearch-Dashboards core and components teams finalize their features
- [ ] Create Jenkins workflows that run daily snapshot builds for OpenSearch and OpenSearch Dashboards.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to an existing workflow/PR/Jenkins?

Signed-off-by: Zelin Hao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #2930 (1daa646) into main (565735b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2930   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files         165      165           
  Lines        4518     4518           
=======================================
  Hits         4202     4202           
  Misses        316      316           
Impacted Files Coverage Δ
src/paths/script_finder.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


### Release Branch - _Ends __REPLACE_RELEASE-minus-14-days__

- [ ] Component versions are auto-incremented to {{ env.VERSION }} version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing period ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated few others as well.

Signed-off-by: Zelin Hao <[email protected]>
@dblock dblock merged commit a7cea5e into opensearch-project:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants