Added runners for enabling concurrent segment search via settings #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
add_operation_enabled_concurrent_segment_search
branch
from
afc6496 to
d25b145
Compare
VijayanB
reviewed
Jul 23, 2024
| @@ -2696,3 +2697,17 @@ async def __call__(self, opensearch, params): | |||
|
|
|||
| def __repr__(self, *args, **kwargs): | |||
| return "deploy-ml-model" | |||
|
|
|||
| class EnableConcurrentSegmentSearch(Runner): | |||
There was a problem hiding this comment.
nit: What do you think about naming as UpdateConcurrentSegmentSearchClusterSettings?
There was a problem hiding this comment.
ack, makes sense if we're adding the slice count param
|
@martin-gaievski Do you have plan to add slice settings as well? |
do you mean setting |
martin-gaievski
force-pushed
the
add_operation_enabled_concurrent_segment_search
branch
from
fdb3cb0 to
034def4
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
add_operation_enabled_concurrent_segment_search
branch
from
034def4 to
41b0429
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added EnableConcurrentSegmentSearch runner, this will be used in semantic search workloads like https://github.com/opensearch-project/opensearch-benchmark-workloads/tree/main/noaa_semantic_search or one that is in PR opensearch-project/opensearch-benchmark-workloads#342
Issues Resolved
building block for opensearch-project/opensearch-benchmark-workloads#341
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.