Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected setting name for max_slice_count #602

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Jul 30, 2024

Description

Need to correct setting name for recently added runner EnableConcurrentSegmentSearch. As per documentation correct setting name is search.concurrent.max_slice_count. With current setting name the runner and calling operation will fail.

Original PR #591

Testing

  • New functionality includes testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski marked this pull request as ready for review July 30, 2024 23:57
@peterzhuamazon
Copy link
Member

Hi @martin-gaievski please rebase your changes with main branch.
We recently add a new workflow to test benchmark docker builds.

Thanks.

@martin-gaievski martin-gaievski force-pushed the fix_runner_for_set_concurrent_seg_search_action branch from 447f4df to 99dd483 Compare August 1, 2024 17:03
@martin-gaievski
Copy link
Member Author

Hi @martin-gaievski please rebase your changes with main branch. We recently add a new workflow to test benchmark docker builds.

Thanks.

thanks Peter, rebased my branch to main

@VijayanB VijayanB merged commit 23b10f0 into opensearch-project:main Aug 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants