Add support to parse response if fields or _source are enabled #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
support-fields
branch
from
d6656bf to
d4add27
Compare
navneet1v
reviewed
Dec 26, 2023
| if id_field in hit: # Will add to candidates if field value is present | ||
| candidates.append(hit[id_field]) | ||
| field_value = _get_field_value(hit, id_field) | ||
| if field_value: # Will add to candidates if field value is present |
There was a problem hiding this comment.
have we tested this if the field_value is 0 ? will this condition work?
There was a problem hiding this comment.
Good point. Let me add test case
There was a problem hiding this comment.
Updated test case and added is None check.
If custom field is used as unique field instead of _id, users can either enable _source to fetch those fields, or, use fields to include only return those fields with or without source. Hence, update parser to look for field name in fields first, and from _source at last. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Maximum number of public method is reached, hence, move vector serach query test methods into separate class. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
support-fields
branch
from
9f07636 to
a523752
Compare
navneet1v
approved these changes
Dec 26, 2023
Will allow body params from workload except query parameter. We will replace that with vector search query. In future we will extend this query to support other features like post filter, efficient filter, etc... Signed-off-by: Vijayan Balasubramanian <[email protected]>
jmazanec15
reviewed
Dec 27, 2023
jmazanec15
approved these changes
Dec 28, 2023
1 task
|
@IanHoang Can you take a look at this PR? |
IanHoang
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If custom field is used as unique field instead of _id, users can either enable _source to fetch those fields, or, use fields to include only return those fields with or without source. Hence, update parser to look for field name in fields first, and from _source at last.
Issues Resolved
Part of #103
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.