Add vector search bulk param and runner #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #427 |
VijayanB
force-pushed
the
add-vector-search-bulk
branch
2 times, most recently
from
2a9eadb to
c0c7d32
Compare
jmazanec15
reviewed
Dec 29, 2023
VijayanB
force-pushed
the
add-vector-search-bulk
branch
from
c0c7d32 to
e03c51b
Compare
VijayanB
changed the title
Added params and runner to support vector search bulk operations. This custom bulk vector search support partitioning files like bigann and hdf5 into multiple bulk request based on bulk size. Signed-off-by: Vijayan Balasubramanian <[email protected]>
VijayanB
force-pushed
the
add-vector-search-bulk
branch
from
e03c51b to
9abca61
Compare
|
Tested this with 128-sift-1M-l2 dataset |
|
@jmazanec15 Can you review updated PR? |
|
@IanHoang Is test failure due to flaky test? |
Unittests have been rerun and passed |
IanHoang
approved these changes
Jan 2, 2024
jmazanec15
approved these changes
Jan 2, 2024
|
@IanHoang Can this be merged? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added params and runner to support vector search
bulk operations. This custom bulk vector search
support partitioning files like bigann and hdf5
into multiple bulk request based on bulk size.
Issues Resolved
Part of #103
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.