Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SourceField mode #652

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Oct 31, 2024

Description

Removed unsupported _common.mapping:SourceField's mode field and associated _common.mapping:SourceFieldMode enum

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Changes Analysis

Commit SHA: 674748e
Comparing To SHA: 1eb43f6

API Changes

Summary

├─┬Info
│ └──[🔀] version (4:12)
└─┬Components
  ├──[➖] schemas (38830:7)❌ 
  └─┬_common.mapping:SourceField
    └──[➖] properties (38827:9)❌ 

Document Element Total Changes Breaking Changes
info 1 0
components 2 2
  • BREAKING Changes: 2 out of 3
  • Modifications: 1
  • Removals: 2
  • Breaking Removals: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11619710912/artifacts/2130591353

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 35 35 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
510 321 (62.94 %)

dblock
dblock previously approved these changes Oct 31, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, thanks.

Since this is a breaking change, bump the version from 0.1.1 to 0.2.0.

Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia dismissed dblock’s stale review October 31, 2024 20:47

The merge-base changed after approval.

@Xtansia Xtansia force-pushed the remove/source-field-mode branch from 3ffbf39 to ebe239c Compare October 31, 2024 20:47
@Xtansia Xtansia requested a review from dblock October 31, 2024 20:48
Signed-off-by: Thomas Farr <[email protected]>
@dblock dblock merged commit 07e329e into opensearch-project:main Oct 31, 2024
22 checks passed
@Xtansia Xtansia deleted the remove/source-field-mode branch October 31, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants