Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin generating index CRUD operations #1220

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Oct 7, 2024

Description

Begin generating indices.get, shortcutting a few of the more expansive types for property mapping and query types etc. Will make follow up PRs to generate them.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia force-pushed the feat/code-gen/indices-get branch from b730726 to 6083075 Compare October 7, 2024 05:09
@Xtansia Xtansia marked this pull request as draft October 7, 2024 05:10
@Xtansia Xtansia force-pushed the feat/code-gen/indices-get branch 5 times, most recently from 92d4e70 to d1b3104 Compare October 9, 2024 10:25
@Xtansia Xtansia marked this pull request as ready for review October 9, 2024 20:19
@Xtansia Xtansia changed the title Begin generating indices.get Begin generating index CRUD operations Oct 10, 2024
dblock
dblock previously approved these changes Oct 11, 2024
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
@Xtansia Xtansia force-pushed the feat/code-gen/indices-get branch from afb4e70 to 4a489a4 Compare October 24, 2024 00:24
@Xtansia Xtansia requested review from reta and dblock October 24, 2024 00:28
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia force-pushed the feat/code-gen/indices-get branch from 4a489a4 to 7347a68 Compare October 31, 2024 01:49
@Xtansia
Copy link
Collaborator Author

Xtansia commented Oct 31, 2024

@dblock @reta Could you please take another look at this? I think I've covered all the comments/concerns.

@dblock dblock merged commit b962e89 into opensearch-project:main Oct 31, 2024
55 of 56 checks passed
@Xtansia Xtansia deleted the feat/code-gen/indices-get branch October 31, 2024 20:38
Xtansia added a commit to Xtansia/opensearch-java that referenced this pull request Nov 3, 2024
* Generate indices.get

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.exists

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.create

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.delete

Signed-off-by: Thomas Farr <[email protected]>

* Cleanup SourceFieldMode

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit b962e89)
Xtansia added a commit that referenced this pull request Nov 4, 2024
* Improve code generation (#1219)

- Render descriptions using markdown
- Support generating "DictionaryResponse" types
- Support discriminated unions

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit d045d86)

* Use latest spec

Signed-off-by: Thomas Farr <[email protected]>

* Add `@Override` to equals & hashCode (#1249)

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 282f415)

* Begin generating index CRUD operations (#1220)

* Generate indices.get

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.exists

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.create

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.delete

Signed-off-by: Thomas Farr <[email protected]>

* Cleanup SourceFieldMode

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit b962e89)

* Generate KnnVectorProperty

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 6a930ad)

* Add PR number

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants