Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for jdk-21 #500

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Nov 30, 2023

Description

Adding jdk-21 support:

  • upgrade gradle to 8.4
  • added jdk-21 to CI configuration

This is a requirement for 2.12 release, core build system already switched to jdk-21 as default one opensearch-project/OpenSearch#11003. I've created a PR to fix this opensearch-project/opensearch-build#4268, but the build for plugin is failing in distribution build CI

Some additional changes:

  • upgrade of spotless plugin, it has new standards which affect many classes. All changes in java files are related to compliance with that new version of spotless.
  • increase max JVM heap to 4Gb as otherwise ml-commons is failing with Circuit Breaker exception

Check List

  • New functionality includes testing.
    • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <[email protected]>
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c338b94) 84.55% compared to head (1b52576) 84.55%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #500   +/-   ##
=========================================
  Coverage     84.55%   84.55%           
  Complexity      532      532           
=========================================
  Files            40       40           
  Lines          1547     1547           
  Branches        244      244           
=========================================
  Hits           1308     1308           
  Misses          128      128           
  Partials        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-gaievski martin-gaievski marked this pull request as ready for review December 6, 2023 06:08
@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch Maintenance Add support for new versions of OpenSearch/Dashboards from upstream labels Dec 6, 2023
@martin-gaievski
Copy link
Member Author

martin-gaievski commented Dec 6, 2023

I've up versioned all libraries that we're referencing directly. For some libraries later version is available, but we're blocked on upgrade due to other packages that we depend on. Unless that's fixed the Mend Security Check will stay there

@martin-gaievski martin-gaievski merged commit 5daddfd into opensearch-project:main Dec 6, 2023
21 of 22 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-500-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5daddfd2f10486ad4688742aa26db82461b6a73c
# Push it to GitHub
git push --set-upstream origin backport/backport-500-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-500-to-2.x.

krishy91 pushed a commit to krishy91/neural-search that referenced this pull request Dec 20, 2023
* Added support for jdk-21

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>
krishy91 pushed a commit to krishy91/neural-search that referenced this pull request Jan 4, 2024
* Added support for jdk-21

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>
krishy91 pushed a commit to krishy91/neural-search that referenced this pull request Jan 4, 2024
* Added support for jdk-21

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>
zane-neo pushed a commit that referenced this pull request Mar 1, 2024
* Handle case with nested list of objects

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* fix validateEmbeddingsFieldValues Method

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* spotless formatting

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Onboard jenkins prod docker images on github actions (#483)

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Update dependency org.json:json to v20231013 (#481)

Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* [Backport main manually][bug fix] Fix async actions are left in neural_sparse query (#438) (#479)

* [bug fix] Fix async actions are left in neural_sparse query (#438)

* add serialization and deserialization

Signed-off-by: zhichao-aws <[email protected]>

* hash, equals. + UT

Signed-off-by: zhichao-aws <[email protected]>

* tidy

Signed-off-by: zhichao-aws <[email protected]>

* add test

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
(cherry picked from commit 51e6c00)

* rm max_token_score

Signed-off-by: zhichao-aws <[email protected]>

* add changelog

Signed-off-by: zhichao-aws <[email protected]>

* tidy

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Fixed exception for case when Hybrid query being wrapped into bool query (#490)

* Adding null check for case when hybrid query wrapped into bool query

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Fixed Hybrid query for cases when it's wrapped into other compound queries (#498)

* Fixed nested field case

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Added the github action to copy the attached issues label to PR. (#504)

Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Added support for jdk-21 (#500)

* Added support for jdk-21

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Add unit tests + small fixes

Signed-off-by: krishy91 <[email protected]>

* fix indentation

Signed-off-by: krishy91 <[email protected]>

* remove unused code + add 2nd level nesting test

Signed-off-by: krishy91 <[email protected]>

* add integration test for list of nested objects

Signed-off-by: krishy91 <[email protected]>

---------

Signed-off-by: Gopala-Krishna.Char <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: krishy91 <[email protected]>
Co-authored-by: Gopala-Krishna.Char <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: Martin Gaievski <[email protected]>
Co-authored-by: Navneet Verma <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 1, 2024
* Handle case with nested list of objects

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* fix validateEmbeddingsFieldValues Method

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* spotless formatting

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Onboard jenkins prod docker images on github actions (#483)

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Update dependency org.json:json to v20231013 (#481)

Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* [Backport main manually][bug fix] Fix async actions are left in neural_sparse query (#438) (#479)

* [bug fix] Fix async actions are left in neural_sparse query (#438)

* add serialization and deserialization

Signed-off-by: zhichao-aws <[email protected]>

* hash, equals. + UT

Signed-off-by: zhichao-aws <[email protected]>

* tidy

Signed-off-by: zhichao-aws <[email protected]>

* add test

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
(cherry picked from commit 51e6c00)

* rm max_token_score

Signed-off-by: zhichao-aws <[email protected]>

* add changelog

Signed-off-by: zhichao-aws <[email protected]>

* tidy

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Fixed exception for case when Hybrid query being wrapped into bool query (#490)

* Adding null check for case when hybrid query wrapped into bool query

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Fixed Hybrid query for cases when it's wrapped into other compound queries (#498)

* Fixed nested field case

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Added the github action to copy the attached issues label to PR. (#504)

Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Added support for jdk-21 (#500)

* Added support for jdk-21

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Add unit tests + small fixes

Signed-off-by: krishy91 <[email protected]>

* fix indentation

Signed-off-by: krishy91 <[email protected]>

* remove unused code + add 2nd level nesting test

Signed-off-by: krishy91 <[email protected]>

* add integration test for list of nested objects

Signed-off-by: krishy91 <[email protected]>

---------

Signed-off-by: Gopala-Krishna.Char <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: krishy91 <[email protected]>
Co-authored-by: Gopala-Krishna.Char <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: Martin Gaievski <[email protected]>
Co-authored-by: Navneet Verma <[email protected]>
(cherry picked from commit ea49d3c)
vibrantvarun pushed a commit that referenced this pull request Mar 5, 2024
* Handle case with nested list of objects

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* fix validateEmbeddingsFieldValues Method

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* spotless formatting

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Onboard jenkins prod docker images on github actions (#483)

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Update dependency org.json:json to v20231013 (#481)

Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* [Backport main manually][bug fix] Fix async actions are left in neural_sparse query (#438) (#479)

* [bug fix] Fix async actions are left in neural_sparse query (#438)

* add serialization and deserialization

Signed-off-by: zhichao-aws <[email protected]>

* hash, equals. + UT

Signed-off-by: zhichao-aws <[email protected]>

* tidy

Signed-off-by: zhichao-aws <[email protected]>

* add test

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
(cherry picked from commit 51e6c00)

* rm max_token_score

Signed-off-by: zhichao-aws <[email protected]>

* add changelog

Signed-off-by: zhichao-aws <[email protected]>

* tidy

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Fixed exception for case when Hybrid query being wrapped into bool query (#490)

* Adding null check for case when hybrid query wrapped into bool query

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Fixed Hybrid query for cases when it's wrapped into other compound queries (#498)

* Fixed nested field case

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Added the github action to copy the attached issues label to PR. (#504)

Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Added support for jdk-21 (#500)

* Added support for jdk-21

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Add unit tests + small fixes

Signed-off-by: krishy91 <[email protected]>

* fix indentation

Signed-off-by: krishy91 <[email protected]>

* remove unused code + add 2nd level nesting test

Signed-off-by: krishy91 <[email protected]>

* add integration test for list of nested objects

Signed-off-by: krishy91 <[email protected]>

---------

Signed-off-by: Gopala-Krishna.Char <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: krishy91 <[email protected]>
Co-authored-by: Gopala-Krishna.Char <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: Martin Gaievski <[email protected]>
Co-authored-by: Navneet Verma <[email protected]>
(cherry picked from commit ea49d3c)

Co-authored-by: Gopala-Krishna Char <[email protected]>
yuye-aws pushed a commit to yuye-aws/neural-search that referenced this pull request Mar 8, 2024
* Handle case with nested list of objects

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* fix validateEmbeddingsFieldValues Method

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* spotless formatting

Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Onboard jenkins prod docker images on github actions (opensearch-project#483)

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Update dependency org.json:json to v20231013 (opensearch-project#481)

Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* [Backport main manually][bug fix] Fix async actions are left in neural_sparse query (opensearch-project#438) (opensearch-project#479)

* [bug fix] Fix async actions are left in neural_sparse query (opensearch-project#438)

* add serialization and deserialization

Signed-off-by: zhichao-aws <[email protected]>

* hash, equals. + UT

Signed-off-by: zhichao-aws <[email protected]>

* tidy

Signed-off-by: zhichao-aws <[email protected]>

* add test

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
(cherry picked from commit 51e6c00)

* rm max_token_score

Signed-off-by: zhichao-aws <[email protected]>

* add changelog

Signed-off-by: zhichao-aws <[email protected]>

* tidy

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Fixed exception for case when Hybrid query being wrapped into bool query (opensearch-project#490)

* Adding null check for case when hybrid query wrapped into bool query

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Fixed Hybrid query for cases when it's wrapped into other compound queries (opensearch-project#498)

* Fixed nested field case

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Added the github action to copy the attached issues label to PR. (opensearch-project#504)

Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Added support for jdk-21 (opensearch-project#500)

* Added support for jdk-21

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Gopala-Krishna.Char <[email protected]>

* Add unit tests + small fixes

Signed-off-by: krishy91 <[email protected]>

* fix indentation

Signed-off-by: krishy91 <[email protected]>

* remove unused code + add 2nd level nesting test

Signed-off-by: krishy91 <[email protected]>

* add integration test for list of nested objects

Signed-off-by: krishy91 <[email protected]>

---------

Signed-off-by: Gopala-Krishna.Char <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Navneet Verma <[email protected]>
Signed-off-by: krishy91 <[email protected]>
Co-authored-by: Gopala-Krishna.Char <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: Martin Gaievski <[email protected]>
Co-authored-by: Navneet Verma <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch Maintenance Add support for new versions of OpenSearch/Dashboards from upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants