Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable memory circuit breaker for integ tests #770

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Jun 3, 2024

Description

Adapt fix in memory circuit breaker of ml-commons (opensearch-project/ml-commons#2469) to integ tests. Doing following:

  • lower heap memory allocation for test cluster from 4 to 2Gb. It has been increased to 4Gb under Added support for jdk-21 #500 to lower the chance of test failure
  • disable memory CB of ml-commons for all integ tests. that will ensure every test executed in cluster with disabled memory CB

Issues Resolved

#689

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski changed the title Make integ tests more stable Disable memory circuit breaker for integ tests Jun 3, 2024
@martin-gaievski martin-gaievski force-pushed the disable_ml-commons_cb_for_integ_tests branch from 820d6bb to 611d8bc Compare June 3, 2024 20:09
@martin-gaievski martin-gaievski added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Jun 3, 2024
@martin-gaievski martin-gaievski marked this pull request as ready for review June 3, 2024 21:40
@martin-gaievski martin-gaievski merged commit 8705980 into opensearch-project:main Jun 4, 2024
112 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 4, 2024
…ts (#770)

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 8705980)
martin-gaievski added a commit that referenced this pull request Jun 4, 2024
…ts (#770) (#772)

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 8705980)

Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch Infrastructure v2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants