[Backport to 2.x] Fixed exception for case when Hybrid query being wrapped into bool query #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
|
@martin-gaievski lets fix the failing workflows. |
working on this, there is a failed backport core PR that needs to be merged first opensearch-project/OpenSearch#11281 |
…ery (opensearch-project#490) * Adding null check for case when hybrid query wrapped into bool query Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit b3c73bd) Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
backport/backport-490-to-2.x
branch
from
6d7ec6e to
83b9fd5
Compare
|
@navneet1v fixed errors, we started upversion to 2.12 PR and few things were missing. |
navneet1v
approved these changes
Nov 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
…ery (#490) (#496) * Adding null check for case when hybrid query wrapped into bool query (cherry picked from commit b3c73bd) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit ef19ffa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of commit b3c73bd to 2.x (from #490)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.