Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Fixed exception for case when Hybrid query being wrapped into bool query #510

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ef19ffa from #496

…ery (#490) (#496)

* Adding null check for case when hybrid query wrapped into bool query

(cherry picked from commit b3c73bd)

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit ef19ffa)
@martin-gaievski martin-gaievski changed the title [Backport 2.11] [Backport to 2.x] Fixed exception for case when Hybrid query being wrapped into bool query [Backport 2.11] Fixed exception for case when Hybrid query being wrapped into bool query Dec 6, 2023
@heemin32
Copy link
Collaborator

heemin32 commented Dec 6, 2023

Non security related PR shouldn't be merged in released branch.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7368edc) 80.75% compared to head (90ab2f8) 81.00%.

Files Patch % Lines
...ensearch/neuralsearch/query/HybridQueryScorer.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.11     #510      +/-   ##
============================================
+ Coverage     80.75%   81.00%   +0.25%     
- Complexity      510      512       +2     
============================================
  Files            41       41              
  Lines          1590     1590              
  Branches        247      247              
============================================
+ Hits           1284     1288       +4     
+ Misses          201      196       -5     
- Partials        105      106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-gaievski
Copy link
Member

closing as change is not applicable to 2.11 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants