Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/multi_tenancy] Make tenant awareness setting static #2968

Conversation

dbwiddis
Copy link
Member

Description

Removes the ability to change the value of the mutiTenancy setting: it must be initialized in opensearch.yml.

Two other small changes:

  • When multiTenancy was false (which is was while I was figuring out how to set it), Remote client search didn't include the index name, thus returning every document in the cluster/collection.
  • improved performance of removing the dot from a system index name from a match-all regex to substring, since I briefly thought this could be a problem when debugging the bug above

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis dbwiddis force-pushed the tenant-setting-static branch from f2f9b65 to 46da2e6 Compare September 18, 2024 03:45
@dbwiddis dbwiddis force-pushed the tenant-setting-static branch from 46da2e6 to 8ec61a4 Compare September 18, 2024 04:06
@dbwiddis dbwiddis force-pushed the tenant-setting-static branch from 8ec61a4 to 52c3a43 Compare September 18, 2024 04:11
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 04:11 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 04:11 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 04:11 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 04:11 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 04:11 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 04:11 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 05:04 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 05:04 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env September 18, 2024 05:04 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os merged commit 696b7ba into opensearch-project:feature/multi_tenancy Oct 16, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants