[Feature/multi_tenancy] Add missing test annotation and fix the failing test it hid #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
sam-herman
as code owners
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
approved these changes
Oct 16, 2024
dbwiddis
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
pyek-bot
approved these changes
Oct 16, 2024
dbwiddis
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
dhrubo-os
merged commit 9498f3d
into
opensearch-project:feature/multi_tenancy
5 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A test added in #2968 was missing
@Testannotation and wasn't running. Enabled the test and fixed the test to pass.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.