Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS DDB SDK client support for remote data store #2553

Merged
merged 8 commits into from
Jun 18, 2024
Merged

AWS DDB SDK client support for remote data store #2553

merged 8 commits into from
Jun 18, 2024

Conversation

arjunkumargiri
Copy link
Contributor

Description

Add AWS DDB implementation of SDK client. This change would allow plugin metadata to be written to AWS DDB tables. Users need to set environment variable REMOTE_METADATA_TYPE as AWSDynamoDB to use DDB as remote plugin metadata store.

Check List

  • New functionality includes testing.
    • [x ] All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@arjunkumargiri arjunkumargiri force-pushed the feature/multi_tenancy branch from 1f8d9aa to 4a979a9 Compare June 13, 2024 19:01
@arjunkumargiri arjunkumargiri force-pushed the feature/multi_tenancy branch from 4a979a9 to 01d49ea Compare June 13, 2024 19:08
@arjunkumargiri arjunkumargiri force-pushed the feature/multi_tenancy branch from 01d49ea to 02668a8 Compare June 13, 2024 20:03
@arjunkumargiri arjunkumargiri force-pushed the feature/multi_tenancy branch from 02668a8 to 1a2f244 Compare June 13, 2024 20:30
@arjunkumargiri
Added javadoc based on feedback
82bddc8 
Signed-off-by: Arjun kumar Giri <[email protected]>
@arjunkumargiri arjunkumargiri force-pushed the feature/multi_tenancy branch from 7b8d351 to 82bddc8 Compare June 17, 2024 20:38
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 17, 2024 20:38 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 17, 2024 20:38 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 17, 2024 20:38 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri marked this pull request as ready for review June 17, 2024 22:08
@dhrubo-os dhrubo-os merged commit 682cede into opensearch-project:feature/multi_tenancy Jun 18, 2024
6 of 12 checks passed
This was referenced Jun 18, 2024
Merged
Merged
@arjunkumargiri arjunkumargiri deleted the feature/multi_tenancy branch June 20, 2024 19:58
@arjunkumargiri arjunkumargiri restored the feature/multi_tenancy branch June 24, 2024 01:23
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 24, 2024 01:38 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 24, 2024 01:38 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 24, 2024 01:38 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 24, 2024 01:38 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 24, 2024 01:38 — with GitHub Actions Inactive
@arjunkumargiri arjunkumargiri temporarily deployed to ml-commons-cicd-env June 24, 2024 01:38 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis left review comments

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjunkumargiri @dhrubo-os @dbwiddis