Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/multi_tenancy] Add Tenant ID to Search API, refactor and add util methods #2576

Merged
merged 3 commits into from
Jun 19, 2024
Merged

[Feature/multi_tenancy] Add Tenant ID to Search API, refactor and add util methods #2576

merged 3 commits into from
Jun 19, 2024

Conversation

dbwiddis
Copy link
Member

Description

  1. Adds tenant ID to SearchDataObjectRequest. It was already added to the other requests in AWS DDB SDK client support for remote data store #2553
  2. Refactors unwrapAndConvertToRuntime static method from SdkClient interface to new SdkClientUtils class
  3. Adds new getRethrownExecutionExceptionRootCause static method to SdkClientUtils class to handle common pattern of throwables from actionGet(). (Have not yet migrated implementations; will do those as part of future PRs.)

Issues Resolved

PR comments on multiple previous PRs.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env June 19, 2024 05:59 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env June 19, 2024 05:59 — with GitHub Actions Inactive
@dbwiddis dbwiddis temporarily deployed to ml-commons-cicd-env June 19, 2024 05:59 — with GitHub Actions Inactive
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env June 19, 2024 05:59 — with GitHub Actions Error
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env June 19, 2024 05:59 — with GitHub Actions Failure
@dbwiddis dbwiddis had a problem deploying to ml-commons-cicd-env June 19, 2024 05:59 — with GitHub Actions Error
@dbwiddis dbwiddis changed the title Add Tenant ID to Search API, refactor and add util methods [Feature/multi_tenancy] Add Tenant ID to Search API, refactor and add util methods Jun 19, 2024
@dhrubo-os dhrubo-os merged commit c15ca42 into opensearch-project:feature/multi_tenancy Jun 19, 2024
7 of 10 checks passed
@dbwiddis dbwiddis deleted the tenant-id branch June 19, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwiddis @dhrubo-os