Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed noop DeleteModelGroup step #427

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

owaiskazi19
Copy link
Member

Description

Didn't forget @dbwiddis comment from here. Removed noop DeleteModelGroup step

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Jan 20, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (789fc4d) 71.85% compared to head (1dcf137) 71.87%.
Report is 2 commits behind head on main.

Files Patch % Lines
...framework/indices/FlowFrameworkIndicesHandler.java 38.46% 39 Missing and 1 partial ⚠️
...ework/transport/CreateWorkflowTransportAction.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #427      +/-   ##
============================================
+ Coverage     71.85%   71.87%   +0.02%     
- Complexity      614      619       +5     
============================================
  Files            79       78       -1     
  Lines          3084     3133      +49     
  Branches        237      238       +1     
============================================
+ Hits           2216     2252      +36     
- Misses          763      774      +11     
- Partials        105      107       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love deleting things!

@dbwiddis dbwiddis merged commit db9a325 into opensearch-project:main Jan 20, 2024
24 of 26 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 20, 2024
Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit db9a325)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Jan 20, 2024
Removed noop DeleteModelGroup step (#427)


(cherry picked from commit db9a325)

Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants