Removed noop DeleteModelGroup step (#427)

Signed-off-by: Owais Kazi <[email protected]>
opensearch-project · Jan 20, 2024 · db9a325 · db9a325
1 parent a6ac83a
commit db9a325
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 79 deletions.
diff --git a/src/main/java/org/opensearch/flowframework/common/WorkflowResources.java b/src/main/java/org/opensearch/flowframework/common/WorkflowResources.java
@@ -17,9 +17,9 @@
 import org.opensearch.flowframework.workflow.CreateIngestPipelineStep;
 import org.opensearch.flowframework.workflow.DeleteAgentStep;
 import org.opensearch.flowframework.workflow.DeleteConnectorStep;
-import org.opensearch.flowframework.workflow.DeleteModelGroupStep;
 import org.opensearch.flowframework.workflow.DeleteModelStep;
 import org.opensearch.flowframework.workflow.DeployModelStep;
+import org.opensearch.flowframework.workflow.NoOpStep;
 import org.opensearch.flowframework.workflow.RegisterAgentStep;
 import org.opensearch.flowframework.workflow.RegisterLocalCustomModelStep;
 import org.opensearch.flowframework.workflow.RegisterLocalPretrainedModelStep;
@@ -48,7 +48,7 @@ public enum WorkflowResources {
     /** Workflow steps for registering/deleting a local OpenSearch provided pretrained model and associated created resource */
     REGISTER_LOCAL_PRETRAINED_MODEL(RegisterLocalPretrainedModelStep.NAME, WorkflowResources.MODEL_ID, DeleteModelStep.NAME),
     /** Workflow steps for registering/deleting a model group and associated created resource */
-    REGISTER_MODEL_GROUP(RegisterModelGroupStep.NAME, WorkflowResources.MODEL_GROUP_ID, DeleteModelGroupStep.NAME),
+    REGISTER_MODEL_GROUP(RegisterModelGroupStep.NAME, WorkflowResources.MODEL_GROUP_ID, NoOpStep.NAME),
     /** Workflow steps for deploying/undeploying a model and associated created resource */
     DEPLOY_MODEL(DeployModelStep.NAME, WorkflowResources.MODEL_ID, UndeployModelStep.NAME),
     /** Workflow steps for creating an ingest-pipeline and associated created resource */

diff --git a/src/main/java/org/opensearch/flowframework/workflow/DeleteModelGroupStep.java b/src/main/java/org/opensearch/flowframework/workflow/DeleteModelGroupStep.java
diff --git a/src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java b/src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
@@ -69,7 +69,7 @@ public WorkflowStepFactory(
         stepMap.put(CreateConnectorStep.NAME, () -> new CreateConnectorStep(mlClient, flowFrameworkIndicesHandler));
         stepMap.put(DeleteConnectorStep.NAME, () -> new DeleteConnectorStep(mlClient));
         stepMap.put(RegisterModelGroupStep.NAME, () -> new RegisterModelGroupStep(mlClient, flowFrameworkIndicesHandler));
-        stepMap.put(DeleteModelGroupStep.NAME, DeleteModelGroupStep::new);
+        stepMap.put(NoOpStep.NAME, NoOpStep::new);
         stepMap.put(ToolStep.NAME, ToolStep::new);
         stepMap.put(RegisterAgentStep.NAME, () -> new RegisterAgentStep(mlClient, flowFrameworkIndicesHandler));
         stepMap.put(DeleteAgentStep.NAME, () -> new DeleteAgentStep(mlClient));

diff --git a/src/main/resources/mappings/workflow-steps.json b/src/main/resources/mappings/workflow-steps.json
@@ -145,11 +145,6 @@
             "opensearch-ml"
         ]
     },
-    "delete_model_group": {
-        "inputs":[],
-        "outputs":[],
-        "required_plugins":[]
-    },
     "register_agent": {
         "inputs":[
             "name",

diff --git a/src/test/java/org/opensearch/flowframework/workflow/DeleteModelGroupTests.java b/src/test/java/org/opensearch/flowframework/workflow/DeleteModelGroupTests.java