Added a noop workflow step to delete model group #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
============================================
+ Coverage 72.30% 72.34% +0.03%
- Complexity 578 581 +3
============================================
Files 72 73 +1
Lines 2986 2990 +4
Branches 231 231
============================================
+ Hits 2159 2163 +4
Misses 723 723
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
add-delete-model-group
branch
from
2814a22 to
f0e7630
Compare
ohltyler
reviewed
Jan 5, 2024
src/main/java/org/opensearch/flowframework/common/WorkflowResources.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/ModelGroupStep.java
Outdated
Show resolved
Hide resolved
amitgalitz
reviewed
Jan 5, 2024
src/main/java/org/opensearch/flowframework/workflow/ModelGroupStep.java
Outdated
Show resolved
Hide resolved
|
Just a heads up, flaky integration tests will be resolved by #377 |
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
add-delete-model-group
branch
from
0c6177b to
7f76221
Compare
Added more details. |
amitgalitz
approved these changes
Jan 5, 2024
ohltyler
approved these changes
Jan 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
(cherry picked from commit 324a56a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
reviewed
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a noop workflow step to delete model group. The reason of the noop step is that the model group is deleted on its own when there are no model in it. To handle the null case in deprovisioning for register model group step, created this noop workflow step to avoid any conflict with the resources created.
Issues Resolved
Fixes #365
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.