Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… attempting to parse from source Signed-off-by: Joshua Palis <[email protected]>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
============================================
- Coverage 81.82% 81.46% -0.37%
Complexity 285 285
============================================
Files 30 30
Lines 1117 1122 +5
Branches 125 126 +1
============================================
Hits 914 914
- Misses 158 162 +4
- Partials 45 46 +1
|
dbwiddis
approved these changes
Oct 17, 2023
owaiskazi19
reviewed
Oct 17, 2023
src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java
Show resolved
Hide resolved
owaiskazi19
approved these changes
Oct 17, 2023
Signed-off-by: Joshua Palis <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
…ument does not exist (#100) * Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source Signed-off-by: Joshua Palis <[email protected]> * Catching topological sorting exceptions when executing the workflow Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 63ef780) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Oct 17, 2023
…ument does not exist (#100) * Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source Signed-off-by: Joshua Palis <[email protected]> * Catching topological sorting exceptions when executing the workflow Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 63ef780) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Joshua Palis <[email protected]>
joshpalis
added a commit
that referenced
this pull request
Oct 17, 2023
… in which a document does not exist (#102) * Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist (#100) * Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source Signed-off-by: Joshua Palis <[email protected]> * Catching topological sorting exceptions when executing the workflow Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 63ef780) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Joshua Palis <[email protected]> * bumping version to 2.12 Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Palis <[email protected]>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
… in which a document does not exist (opensearch-project#102) * Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist (opensearch-project#100) * Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source Signed-off-by: Joshua Palis <[email protected]> * Catching topological sorting exceptions when executing the workflow Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 63ef780) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Joshua Palis <[email protected]> * bumping version to 2.12 Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Palis <[email protected]>
dbwiddis
pushed a commit
to dbwiddis/flow-framework
that referenced
this pull request
Dec 18, 2023
… in which a document does not exist (opensearch-project#102) * Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist (opensearch-project#100) * Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source Signed-off-by: Joshua Palis <[email protected]> * Catching topological sorting exceptions when executing the workflow Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 63ef780) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Joshua Palis <[email protected]> * bumping version to 2.12 Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Palis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse the use case template document from the response source
Issues Resolved
Part of #88
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.