Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist #102

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 63ef780 from #100.

…ument does not exist (#100)

* Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>

* Catching topological sorting exceptions when executing the workflow

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 63ef780)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joshua Palis <[email protected]>
@joshpalis joshpalis force-pushed the backport/backport-100-to-2.x branch from 3382b58 to f60d045 Compare October 17, 2023 17:36
@joshpalis
Copy link
Member

/home/runner/work/opensearch-ai-flow-framework/opensearch-ai-flow-framework/src/main/java/org/opensearch/flowframework/workflow/RegisterModelStep.java:142: error: cannot find symbol

            machineLearningNodeClient.register(mlInput, actionListener);
                                     ^
  symbol:   method register(MLRegisterModelInput,ActionListener<MLRegisterModelResponse>)
> Task :compileJava
  location: variable machineLearningNodeClient of type MachineLearningNodeClient
/home/runner/work/opensearch-ai-flow-framework/opensearch-ai-flow-framework/src/main/java/org/opensearch/flowframework/workflow/DeployModelStep.java:73: error: cannot find symbol

        machineLearningNodeClient.deploy(modelId, actionListener);
                                 ^
> Task :compileJava FAILED
  symbol:   method deploy(String,ActionListener<MLDeployModelResponse>)
  location: variable machineLearningNodeClient of type MachineLearningNodeClient
2 errors

Seems that ML-commons did not backport register and deploy into 2.11 before cutting the branch. Will have to bump up our 2.x version to 2.12

Signed-off-by: Joshua Palis <[email protected]>
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #102 (7ca967b) into 2.x (19c8935) will decrease coverage by 0.37%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                2.x     #102      +/-   ##
============================================
- Coverage     81.82%   81.46%   -0.37%     
  Complexity      285      285              
============================================
  Files            30       30              
  Lines          1117     1122       +5     
  Branches        125      126       +1     
============================================
  Hits            914      914              
- Misses          158      162       +4     
- Partials         45       46       +1     
Files Coverage Δ
...rk/transport/ProvisionWorkflowTransportAction.java 45.61% <0.00%> (-4.39%) ⬇️

@joshpalis joshpalis merged commit a653645 into 2.x Oct 17, 2023
25 of 26 checks passed
@github-actions github-actions bot deleted the backport/backport-100-to-2.x branch October 17, 2023 18:22
dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Dec 18, 2023
… in which a document does not exist (opensearch-project#102)

* Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist (opensearch-project#100)

* Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>

* Catching topological sorting exceptions when executing the workflow

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 63ef780)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joshua Palis <[email protected]>

* bumping version to 2.12

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Palis <[email protected]>
dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Dec 18, 2023
… in which a document does not exist (opensearch-project#102)

* Fixing ProvisionWorkflowTransportAction, handling case in which a document does not exist (opensearch-project#100)

* Fixing bug, handling case in which a GC entry does not exist prior to attempting to parse from source

Signed-off-by: Joshua Palis <[email protected]>

* Catching topological sorting exceptions when executing the workflow

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit 63ef780)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Joshua Palis <[email protected]>

* bumping version to 2.12

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Palis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant