-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard Stylelint #229
Onboard Stylelint #229
Conversation
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 5 5
Lines 152 152
Branches 45 45
=======================================
Hits 144 144
Misses 8 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Signed-off-by: Derek Ho <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-visualizations/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-visualizations/backport-2.x
# Create a new branch
git switch --create backport/backport-229-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37a3545ed266794744f1ea5e4f593c982b0341e2
# Push it to GitHub
git push --set-upstream origin backport/backport-229-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-visualizations/backport-2.x Then, create a pull request where the |
(cherry picked from commit 37a3545)
(cherry picked from commit 37a3545) Co-authored-by: Matt Provost <[email protected]>
Description
Adds new
yarn lint:style
script that runs Stylelint and runs it in the build and test workflow. This should help make sure new Sass isn't written with anti-patterns.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.