Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Stylelint #229

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Aug 22, 2023

Description

Adds new yarn lint:style script that runs Stylelint and runs it in the build and test workflow. This should help make sure new Sass isn't written with anti-patterns.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #229 (a7ec2b8) into main (935b6d9) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

joshuali925
joshuali925 previously approved these changes Oct 4, 2023
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho merged commit 37a3545 into opensearch-project:main Oct 18, 2023
9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-visualizations/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-visualizations/backport-2.x
# Create a new branch
git switch --create backport/backport-229-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37a3545ed266794744f1ea5e4f593c982b0341e2
# Push it to GitHub
git push --set-upstream origin backport/backport-229-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-visualizations/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-229-to-2.x.

ps48 pushed a commit to ps48/dashboards-visualizations that referenced this pull request Dec 13, 2023
@ps48 ps48 mentioned this pull request Dec 13, 2023
6 tasks
mengweieric pushed a commit that referenced this pull request Dec 13, 2023
(cherry picked from commit 37a3545)

Co-authored-by: Matt Provost <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants