Onboard Stylelint (#229)

opensearch-project · Oct 18, 2023 · 37a3545 · 37a3545
1 parent cb4df73
commit 37a3545
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/.github/workflows/test-and-build-workflow.yml b/.github/workflows/test-and-build-workflow.yml
@@ -51,6 +51,11 @@ jobs:
           cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
           yarn osd bootstrap
 
+      - name: Run Stylelint
+        run: |
+          cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
+          yarn lint:style
+
       - name: Test
         run: |
           cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
@@ -117,6 +122,11 @@ jobs:
           cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
           yarn osd bootstrap
 
+      - name: Run Stylelint
+        run: |
+          cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
+          yarn lint:style
+
       - name: Test
         run: |
           cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
@@ -175,6 +185,11 @@ jobs:
           cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
           yarn osd bootstrap
 
+      - name: Run Stylelint
+        run: |
+          cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart
+          yarn lint:style
+
       - name: Test
         run: |
           cd ./dashboards-visualizations/OpenSearch-Dashboards/plugins/gantt-chart

diff --git a/gantt-chart/package.json b/gantt-chart/package.json
@@ -6,6 +6,7 @@
     "osd": "node ../../scripts/osd",
     "opensearch": "node ../../scripts/opensearch",
     "lint": "eslint .",
+    "lint:style": "node ../../scripts/stylelint",
     "build": "yarn plugin-helpers build",
     "plugin-helpers": "node ../../scripts/plugin_helpers",
     "test": "../../node_modules/.bin/jest --config ./test/jest.config.js",

diff --git a/gantt-chart/public/index.scss b/gantt-chart/public/index.scss
@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-.embPanel__content[data-loading][data-type=plotlyGanttChart] {
+.embPanel__content[data-loading][data-type="plotlyGanttChart"] {
   pointer-events: auto;
   filter: none;
 }