Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Turn on olly II features in OSD #230

Closed
wants to merge 1 commit into from
Closed

[Enhancement] Turn on olly II features in OSD #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion config/playground/helm/dev/helm-opensearch-dashboards.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,12 @@ extraObjects: []
# specify the external plugins to install.
plugins:
enabled: true
installList: ["https://github.com/BionIT/google-analytics-plugin/releases/download/2.18.0/googleAnalytics-2.18.0.zip"]
installList: ["https://github.com/BionIT/google-analytics-plugin/releases/download/2.18.0/googleAnalytics-2.18.0.zip"]

# Olly II features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks yuye, have you been verify it from your local? Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Is there a guide for deploying to the playground website? I cannot find the required credentials here

assistant.enabled: true

assistant.text2viz.enabled: true
assistant.alertInsight.enabled: true
assistant.smartAnomalyDetector.enabled: true
queryEnhancements.queryAssist.summary.enabled: true
10 changes: 9 additions & 1 deletion config/playground/helm/prod/helm-opensearch-dashboards.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,12 @@ extraObjects: []
# specify the external plugins to install
plugins:
enabled: true
installList: ["https://github.com/BionIT/google-analytics-plugin/releases/download/2.18.0/googleAnalytics-2.18.0.zip"]
installList: ["https://github.com/BionIT/google-analytics-plugin/releases/download/2.18.0/googleAnalytics-2.18.0.zip"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we do not enable dev and prod at the same time. We need to enable dev first, verify it works, and then enable prod. Can this PR enable only dev for now? After verification, we can enable prod with another PR. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not hurry. Let's merge this PR after I've verified it locally in dev.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you take a look the github action in this repo, it is monitoring the file changes from folder, https://github.com/opensearch-project/dashboards-anywhere/blob/main/.github/workflows/os-osd-deployment.yml#L26, you need to update your PR only have dev file changes, it will trigger dev env deployment, then you can verify if your changes works. after everything works expected, then create another PR for modify the PROD file.


# Olly II features
assistant.enabled: true

assistant.text2viz.enabled: true
assistant.alertInsight.enabled: true
assistant.smartAnomalyDetector.enabled: true
queryEnhancements.queryAssist.summary.enabled: true