[Enhancement] Turn on olly II features in OSD #230
Conversation
Signed-off-by: yuye-aws <[email protected]>
yuye-aws
requested review from
seraphjiang,
Flyingliuhub,
BionIT and
zengyan-amazon
as code owners
|
This is the first time I'm contributing to this repo. Please let me know if both |
| installList: ["https://github.com/BionIT/google-analytics-plugin/releases/download/2.18.0/googleAnalytics-2.18.0.zip"] | ||
|
|
||
| # Olly II features |
There was a problem hiding this comment.
Thanks yuye, have you been verify it from your local? Thanks
There was a problem hiding this comment.
No. Is there a guide for deploying to the playground website? I cannot find the required credentials here
| installList: ["https://github.com/BionIT/google-analytics-plugin/releases/download/2.18.0/googleAnalytics-2.18.0.zip"] |
There was a problem hiding this comment.
Usually, we do not enable dev and prod at the same time. We need to enable dev first, verify it works, and then enable prod. Can this PR enable only dev for now? After verification, we can enable prod with another PR. Thanks!
There was a problem hiding this comment.
It's not hurry. Let's merge this PR after I've verified it locally in dev.
There was a problem hiding this comment.
If you take a look the github action in this repo, it is monitoring the file changes from folder, https://github.com/opensearch-project/dashboards-anywhere/blob/main/.github/workflows/os-osd-deployment.yml#L26, you need to update your PR only have dev file changes, it will trigger dev env deployment, then you can verify if your changes works. after everything works expected, then create another PR for modify the PROD file.
|
I'm closing this PR as it is no longer needed. Thanks for paying attention to this PR @Flyingliuhub ! |
Description
This PR turns on olly II features in OSD for https://playground.opensearch.org/
Issues Resolved
Issue #229
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.