Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ClusterBlock description 'no master' to 'no cluster-manager' #3133

Merged

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented May 2, 2022

Description

To support inclusive language, replace "master" with "cluster manager".
There is no compatibility concern with this code change.

  • Rename the description of ClusterBlock NO_MASTER_BLOCK_... from no master to no cluster-manager
  • Modify all other usages of no master to no cluster-manager

Issues Resolved

A part of #1548

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b10f43b
Log 4910

Reports 4910

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 8faffe1
Log 4921

Reports 4921

@tlfeng tlfeng added v2.1.0 Issues and PRs related to version 2.1.0 backport 2.x Backport to 2.x branch labels May 3, 2022
@tlfeng tlfeng marked this pull request as ready for review May 3, 2022 04:30
@tlfeng tlfeng requested review from a team and reta as code owners May 3, 2022 04:30
@dblock dblock merged commit bb870f7 into opensearch-project:main May 3, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2022
…3133)

* Rename ClusterBlock description 'no master' to 'no cluster-manager'

Signed-off-by: Tianli Feng <[email protected]>

* Adjust format by spotlessApply task

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit bb870f7)
dblock pushed a commit that referenced this pull request May 3, 2022
…3133) (#3151)

* Rename ClusterBlock description 'no master' to 'no cluster-manager'

Signed-off-by: Tianli Feng <[email protected]>

* Adjust format by spotlessApply task

Signed-off-by: Tianli Feng <[email protected]>
(cherry picked from commit bb870f7)

Co-authored-by: Tianli Feng <[email protected]>
@tlfeng tlfeng deleted the rename-cluster-block-description branch May 3, 2022 17:28
@tlfeng
Copy link
Collaborator Author

tlfeng commented May 3, 2022

@dblock Thank your for your time in reviewing the PR! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants