Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "master" terminology in code comments, and internal variable, method and class names #1548

Closed
12 tasks done
tlfeng opened this issue Nov 15, 2021 · 1 comment
Closed
12 tasks done
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0

Comments

@tlfeng
Copy link
Collaborator

tlfeng commented Nov 15, 2021

Is your feature request related to a problem? Please describe.
Replace "master" terminology in the code base, but only the places that won't impact the backwards compatibility.

A part of #472

Describe the solution you'd like
Replace all the "master" terminology in the following location:

  • "master branch" in documents
  • code comments
  • internal variable, method and class names

Any APIs or configurations will not be impacted.

Directories:

The issue to track "master" word in Log messages: #2539

There are 3 usages with "master" terminology in server directory that need to be replaced in caution:

Describe alternatives you've considered
None.

Additional context
None.

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request untriaged labels Nov 15, 2021
@tlfeng tlfeng added v1.3.0 and removed untriaged labels Nov 15, 2021
@tlfeng tlfeng self-assigned this Feb 16, 2022
@tlfeng tlfeng added v2.0.0 Version 2.0.0 and removed v1.3.0 labels Mar 8, 2022
@tlfeng tlfeng added v2.1.0 Issues and PRs related to version 2.1.0 and removed v2.0.0 Version 2.0.0 labels Apr 12, 2022
@tlfeng
Copy link
Collaborator Author

tlfeng commented May 26, 2022

Nearly all the usage of master terminology in internal variable, method and class names have been replaced by cluster manager, so close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
1 participant