-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename BecomeMasterTask to BecomeClusterManagerTask in JoinTaskExecutor #3099
Merged
dblock
merged 1 commit into
opensearch-project:main
from
tlfeng:rename-join-cluster-manager-task
Apr 28, 2022
Merged
Rename BecomeMasterTask to BecomeClusterManagerTask in JoinTaskExecutor #3099
dblock
merged 1 commit into
opensearch-project:main
from
tlfeng:rename-join-cluster-manager-task
Apr 28, 2022
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianli Feng <[email protected]>
tlfeng
added
v3.0.0
Issues and PRs related to version 3.0.0
backport 2.x
Backport to 2.x branch
labels
Apr 28, 2022
Closed
12 tasks
reta
approved these changes
Apr 28, 2022
andrross
approved these changes
Apr 28, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3099-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 017773c62d345edac607b4474bac99f200c560f8
# Push it to GitHub
git push --set-upstream origin backport/backport-3099-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-3099-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 017773c62d345edac607b4474bac99f200c560f8
# Push it to GitHub
git push --set-upstream origin backport/backport-3099-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0 Then, create a pull request where the |
tlfeng
added
the
pending backport
Identifies an issue or PR that still needs to be backported
label
Apr 28, 2022
tlfeng
pushed a commit
to tlfeng/OpenSearch
that referenced
this pull request
May 4, 2022
…or (opensearch-project#3099) Signed-off-by: Tianli Feng <[email protected]>
tlfeng
removed
the
pending backport
Identifies an issue or PR that still needs to be backported
label
May 4, 2022
5 tasks
dblock
pushed a commit
that referenced
this pull request
May 5, 2022
…or (#3099) (#3179) Signed-off-by: Tianli Feng <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 5, 2022
…or (#3099) (#3179) Signed-off-by: Tianli Feng <[email protected]> (cherry picked from commit 2c3cc0a)
tlfeng
pushed a commit
that referenced
this pull request
May 6, 2022
…or (#3099) (#3179) (#3208) Signed-off-by: Tianli Feng <[email protected]> (cherry picked from commit 2c3cc0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
backport 2.0
Backport to 2.0 branch
v2.0.0
Version 2.0.0
v3.0.0
Issues and PRs related to version 3.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a
ClusterStateTask
with identifier_BECOME_MASTER_TASK_
used to indicate the node to be the cluster manager node when joining the cluster.To support inclusive language, and finally change the "master" terminology, I made the following plan:
In version 2.0:
_BECOME_MASTER_TASK_
_BECOME_CLUSTER_MANAGER_TASK_
isBecomeMasterTask()
to accept the 2 namesIn version 3.0:
_BECOME_MASTER_TASK_
The reason not change the name in-place:
The related methods are public methods, in case there are clients that call these method in a mixed version cluster of 1.x and 2.x, this way can keep the compatibility of using these methods with version 1.x cluster.
Issues Resolved
A part of #1548
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.