Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove endpoint_suffix dependency on account key #2761

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 365e07c from #2485

Signed-off-by: Raphael Lopez <[email protected]>
(cherry picked from commit 365e07c)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 5, 2022 00:13
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 3afcb28
Log 4169

Reports 4169

@dblock
Copy link
Member

dblock commented Apr 5, 2022

@raphlopez I am afraid you'll have to manually backport this, see DCO error (not sure what the right way to fix that is)

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 6, 2022

Hi @dblock , looks like @nknize found a way to fix the DCO check in this situation, which is adding an additional line of sign-off. (#2654 (comment)) 😄

Can be achieved by either one:

  1. Adding a line of sign-off by another person.
  2. Adding a line of the required sign-off that requested by the DCO App (in this case: Signed-off-by: Raphael Lopez <[email protected]>)

image

@dblock
Copy link
Member

dblock commented Apr 6, 2022

@tlfeng Feel free to do this and push an update to this auto-PR, but I'd prefer the author of the original PR ensure that things get backported everywhere needed.

@raphlopez
Copy link
Contributor

raphlopez commented Apr 7, 2022

I created a couple separate PRs to manually backport to 2.x and 2.0:

Seems the DCO check already passed for both of them. Let me know if I did that correctly or if there's anything I need to change.

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 7, 2022

@raphlopez Thanks for your time in creating the 2 PRs!
You've done correctly. Sorry about the trouble with the DCO check, the application uses a weird criteria to check the author name and email for cherry-picked commits. 😅
I will close this PR.

@tlfeng tlfeng closed this Apr 7, 2022
@peterzhuamazon peterzhuamazon deleted the backport/backport-2485-to-2.x branch July 8, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants