Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0] Remove endpoint_suffix dependency on account key #2762

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 365e07c from #2485

Signed-off-by: Raphael Lopez <[email protected]>
(cherry picked from commit 365e07c)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 5, 2022 00:14
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 8d923c4
Log 4170

Reports 4170

@dblock
Copy link
Member

dblock commented Apr 5, 2022

@raphlopez I am afraid you'll have to manually backport this, see DCO error (not sure what the right way to fix that is)

@nknize do we want to backport this into 2.0 or not?

@raphlopez
Copy link
Contributor

@dblock thanks for the info. On a similar note, is there any possibility for this to be backported into the next 1.x release? I'm still not quite familiar with the release cycles for this project, so any info on if/how that can be achieved would be appreciated.

@dblock
Copy link
Member

dblock commented Apr 5, 2022

@dblock thanks for the info. On a similar note, is there any possibility for this to be backported into the next 1.x release? I'm still not quite familiar with the release cycles for this project, so any info on if/how that can be achieved would be appreciated.

There's not going to be a 1.4 (next is 2.0) and 1.3.x is only taking security fixes AFAIK. @CEHENKLE what's the guideline for this?

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 8, 2022

The PR is replaced by #2808 due to the DCO check failure (#2761 (comment)).

@dblock
Copy link
Member

dblock commented Apr 11, 2022

Thanks for doing these @raphlopez

#2808
#2807

@dblock dblock closed this Apr 11, 2022
@peterzhuamazon peterzhuamazon deleted the backport/backport-2485-to-2.0 branch July 8, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants