Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0] Add resource stats to task framework #2654

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8b997c1 from #2089

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 29, 2022 18:23
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9bebecd
Log 3870

Reports 3870

@sruti1312
Copy link
Contributor

@dblock Can you help with retrying the CI and merging this commit into 2.0?

@dblock
Copy link
Member

dblock commented Apr 5, 2022

@dblock Can you help with retrying the CI and merging this commit into 2.0?

On it. Next time when you see a gradle check failure do open the log and extract the error, and make sure we have an issue on it.

> Task :example-plugins:custom-settings:compileJava FAILED
/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/plugins/examples/custom-settings/src/main/java/org/opensearch/example/customsettings/ExampleCustomSettingsConfig.java:99: error: cannot find symbol
        final Path configDir = environment.configFile();
                                          ^
  symbol:   method configFile()
  location: variable environment of type Environment
1 error

#2763

@dblock
Copy link
Member

dblock commented Apr 5, 2022

@sruti1312 DCO check above failed, I think you'll have to reopen this one by hand

@dblock
Copy link
Member

dblock commented Apr 5, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 9bebecd
Log 4171

Reports 4171

Adds resource stats to task framework

Signed-off-by: sruti1312 <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit 8b997c1)
@nknize nknize force-pushed the backport/backport-2089-to-2.0 branch from 9bebecd to 7547928 Compare April 5, 2022 03:50
@nknize
Copy link
Collaborator

nknize commented Apr 5, 2022

Fixing DCO check... need this to merge as it's killing mixedCluster bwc testing: #2757

This needs to merge first then I'll take care of the 2.1 backport. That's why 2.1 bwc tests are failing.

@nknize
Copy link
Collaborator

nknize commented Apr 5, 2022

Hold up.. 2.0.0 is feature frozen. Why are we trying to squeeze this in?

@nknize nknize self-requested a review April 5, 2022 03:58
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we determine if we really want to jam in after 2.0 feature freeze.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 7547928
Log 4178

Reports 4178

@sruti1312
Copy link
Contributor

sruti1312 commented Apr 5, 2022

This can included for 2.1 considering that PR that actually populates/adds resource consumption information to the Task.class is still open and not merged yet.

@dblock
Copy link
Member

dblock commented Apr 5, 2022

[Backport 2.x] Add resource stats to task framework #2655

Let's close the backport to 2.0 then.

@dblock dblock closed this Apr 5, 2022
@andrross andrross deleted the backport/backport-2089-to-2.0 branch October 17, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants