Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] Type mapping parameter from document update API #2204

Merged

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Feb 21, 2022

Description

With types deprecation, this change removes type mapping API end-points provided for document update API end-point.

relates 1940

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89 dreamer-89 requested a review from a team as a code owner February 21, 2022 23:03
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 6197384
Log 2675

Reports 2675

@dreamer-89
Copy link
Member Author

distribution:docker:buildDockerImage failure.

> Task :distribution:docker:buildDockerImage FAILED
Exec output and error:
| Output for docker:Sending build context to Docker daemon  223.8MB

| Step 1/27 : FROM centos:8 AS builder
|  ---> 5d0da3dc9764
| Step 2/27 : RUN set -eux ;     tini_bin="" ;     case "$(arch)" in         aarch64) tini_bin='tini-arm64' ;;         x86_64)  tini_bin='tini-amd64' ;;         *) echo >&2 ; echo >&2 "Unsupported architecture $(arch)" ; echo >&2 ; exit 1 ;;     esac ;     curl --retry 8 -S -L -O https://github.com/krallin/tini/releases/download/v0.19.0/${tini_bin} ;     curl --retry 8 -S -L -O https://github.com/krallin/tini/releases/download/v0.19.0/${tini_bin}.sha256sum ;     sha256sum -c ${tini_bin}.sha256sum ;     rm ${tini_bin}.sha256sum ;     mv ${tini_bin} /tini ;     chmod +x /tini
|  ---> Running in 9835ec6dddae
| �[91m+ tini_bin=
| + case "$(arch)" in
| �[0m�[91m++ arch
| �[0m�[91m+ tini_bin=tini-amd64
| + curl --retry 8 -S -L -O https://github.com/krallin/tini/releases/download/v0.19.0/tini-amd64
| �[0m�[91m  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
|    �[0m�[91m                              Dload  Upload   Total   S�[0m�[91mpent    Left  Speed

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 6197384
Log 2678

Reports 2678

@dreamer-89
Copy link
Member Author

Another flaky test failure

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.MinimumMasterNodesIT.testTwoNodesNoMasterBlock" -Dtests.seed=7364F0CAD67E19B5 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=el-CY -Dtests.timezone=Asia/Katmandu -Druntime.java=17

org.opensearch.cluster.MinimumMasterNodesIT > testTwoNodesNoMasterBlock FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([7364F0CAD67E19B5:BF31DBCC73D60CD8]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:985)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:924)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:913)
        at org.opensearch.cluster.MinimumMasterNodesIT.testTwoNodesNoMasterBlock(MinimumMasterNodesIT.java:223)

@dreamer-89
Copy link
Member Author

start gradle check

@dreamer-89 dreamer-89 changed the title Type mapping removall from rest update action Type mapping removal from rest update action Feb 22, 2022
@dreamer-89 dreamer-89 changed the title Type mapping removal from rest update action [Remove] Type mapping parameter from document update API Feb 22, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 6197384
Log 2684

Reports 2684

@dreamer-89 dreamer-89 mentioned this pull request Feb 22, 2022
67 tasks
@dreamer-89
Copy link
Member Author

Again failed due to build docker image test

**> Task :distribution:docker:buildDockerImage FAILED
Exec output and error:
| Output for docker:Sending build context to Docker daemon  223.9MB

| Step 1/27 : FROM centos:8 AS builder
|  ---> 5d0da3dc9764
| Step 2/27 : RUN set -eux ;     tini_bin="" ;     case "$(arch)" in         aarch64) tini_bin='tini-arm64' ;;         x86_64)  tini_bin='tini-amd64' ;;         *) echo >&2 ; echo >&2 "Unsupported architecture $(arch)" ; echo >&2 ; exit 1 ;;     esac ;     curl --retry 8 -S -L -O https://github.com/krallin/tini/releases/download/v0.19.0/${tini_bin} ;     curl --retry 8 -S -L -O https://github.com/krallin/tini/releases/download/v0.19.0/${tini_bin}.sha256sum ;     sha256sum -c ${tini_bin}.sha256sum ;     rm ${tini_bin}.sha256sum ;     mv ${tini_bin} /tini ;     chmod +x /tini
|  ---> Running in ffd70daea2e5
| �[91m+ tini_bin=
| + case "$(arch)" in
| �[0m�[91m++ arch
| �[0m�[91m+ tini_bin=tini-amd64
| + curl --retry 8 -S -L -O https://github.com/krallin/tini/releases/download/v0.19.0/tini-amd64
**

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 6197384
Log 2699

Reports 2699

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx!

@dreamer-89 dreamer-89 merged commit 52eaf96 into opensearch-project:main Feb 22, 2022
@dreamer-89 dreamer-89 added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >breaking Identifies a breaking change. Indexing & Search labels Mar 21, 2022
@dreamer-89 dreamer-89 deleted the type_remove_rest_update branch December 14, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking Identifies a breaking change. Indexing & Search non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants